Skip to content

Await array elements #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025
Merged

Conversation

aslakhellesoy
Copy link
Contributor

First off - thanks for this amazing library! ❤️

I've got some input with arrays of promises. Accessing properties of these array elements results in undefined.

This PR fixes this. I've added a test and all other tests are green.

Copy link
Member

@andrew-coleman andrew-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@andrew-coleman
Copy link
Member

@mattbaileyuk are you happy with this?

Copy link
Member

@mattbaileyuk mattbaileyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, been slow to get back to PRs and issues recently. This looks good me - thanks @aslakhellesoy 👍

@mattbaileyuk mattbaileyuk merged commit d1958d0 into jsonata-js:master Jul 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants